SRE-3607: Fix linter issue reporting#8
Merged
Merged
Conversation
Fix issue where a later linter success could prevent the reporting of an earlier linter failure. - .flake8: New file, that will allow longer than 79 character lines. - README.md: Documentation fixes. - bin/run-linters.sh: Fix reporting of issues. - bin/sync-consumer.sh: Add .flake8 to initial file list. - checks/linters/groovylint/check-implicit-bindings.sh: Fix false positive for environment block in Jenkinsfiles. - vscode-project-words.txt: Minor update. Signed-off-by: John E. Malmberg <john.malmberg@hpe.com>
JohnMalmberg
requested review from
grom72,
janekmi,
jzarzycki,
osalyk and
ryon-jensen
ryon-jensen
approved these changes
Jun 2, 2026
ryon-jensen
left a comment
ryon-jensen
left a comment
There was a problem hiding this comment.
some of the bash is a little complicated for me, but I think it looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue where a later linter success could prevent the reporting of an earlier linter failure.
.flake8: New file, that will allow longer than 79 character lines.
README.md: Documentation fixes.
bin/run-linters.sh: Fix reporting of issues.
bin/sync-consumer.sh: Add .flake8 to initial file list.
checks/linters/groovylint/check-implicit-bindings.sh: Fix false positive for environment block in Jenkinsfiles.
vscode-project-words.txt: Minor update.